rename project to polkadot-staking-miner#717
Merged
Conversation
niklasad1
commented
Nov 27, 2023
| edition = "2021" | ||
| rust-version = "1.70.0" | ||
| license = "GPL-3.0" | ||
| repository = "https://github.com/paritytech/polkadot-staking-miner" |
Contributor
Author
There was a problem hiding this comment.
I'll change this repo name as well if we agree :)
niklasad1
commented
Nov 27, 2023
|
|
||
| ```bash | ||
| $ cargo run --release --package polkadot --features fast-runtime -- --chain polkadot-dev --tmp --alice --execution Native -lruntime=debug --offchain-worker=Never --ws-port 9999 | ||
| $ cargo run --release --package polkadot --features fast-runtime -- --chain westend-dev --tmp --alice --execution Native -lruntime=debug --offchain-worker=Never --ws-port 9999 |
Contributor
Author
There was a problem hiding this comment.
polkadot-dev is removed nowdays
niklasad1
commented
Nov 27, 2023
niklasad1
commented
Nov 27, 2023
|
|
||
| ## Related projects | ||
|
|
||
| - [polkadot staking miner](https://github.com/paritytech/polkadot/tree/master/utils/staking-miner) - provides similar functionality but each release is hard-coded to a specific runtime version |
Contributor
Author
There was a problem hiding this comment.
This is removed as well.
gpestana
approved these changes
Nov 27, 2023
Contributor
gpestana
left a comment
gpestana
left a comment
There was a problem hiding this comment.
Renaming the repo and binary to polkadot-staking-miner sounds good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have reserved
polkadot-staking-mineron crates.io becausestaking-minerwas reserved already.To able to publish the binary to crates.io then this project has to renamed to polkadot-staking-miner is that okay?
We could keep binary name to
staking-minerbut I think that is confusing, so all good to call it "polkadot-staking-miner"?Close #680